Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide admin-option to disable autocomplete in search #1070

Closed
Hallbergs opened this issue May 3, 2022 · 2 comments · Fixed by #1071
Closed

Provide admin-option to disable autocomplete in search #1070

Hallbergs opened this issue May 3, 2022 · 2 comments · Fixed by #1071
Assignees
@Hallbergs
Labels
module:client/core Core functionality (not a plugin) new feature Request for adding/changing functionality
Milestone
3.10

Comments

@Hallbergs
Copy link
Member

Hallbergs commented May 3, 2022 •
edited
Loading

In some Hajk-setups the autocomplete-functionality in Hajk seems to do more harm than good. For instance, some users seems to believe that the autocomplete-list is the actual search-results (making them a bit disappointed when they don't find what they are looking for).

Let's provide an admin-option that can be used to disable the autocomplete, and show the actual results right away instead.

With autocomplete active: (We show the autocomplete after around 300ms)
autocomplete_search

With autocomplete disabled: (We jump straight to the results after around 300ms)
regular_search
@Hallbergs Hallbergs added module:client/core Core functionality (not a plugin) new feature Request for adding/changing functionality labels May 3, 2022
@Hallbergs Hallbergs added this to the 3.x milestone May 3, 2022
@Hallbergs Hallbergs self-assigned this May 3, 2022
Hallbergs added a commit that referenced this issue May 3, 2022
@Hallbergs
Added option to disable the autoComplete in the client (#1070)
4379637
Hallbergs added a commit that referenced this issue May 3, 2022
@Hallbergs
Added the disableAutocomplete option to admin. Closes #1070
2ba7e17
@Hallbergs Hallbergs mentioned this issue May 3, 2022
Merged
@Hallbergs Hallbergs modified the milestones: 3.x, 3.10 May 3, 2022
@Hallbergs Hallbergs linked a pull request May 3, 2022 that will close this issue
Option to disable autocomplete #1071
Merged
@Hallbergs
Copy link
Member Author

Hallbergs commented May 3, 2022 •
edited
Loading

Just linked a pr (#1071) to close this @jesade-vbg @maan002. Please check that it works as you intended.

@jacobwod
Copy link
Member

jacobwod commented May 3, 2022

Really useful addition, great to have the option available! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hallbergs Hallbergs

Labels
module:client/core Core functionality (not a plugin) new feature Request for adding/changing functionality
Projects
None yet
Milestone
3.10
Development

Successfully merging a pull request may close this issue.

Option to disable autocomplete hajkmap/Hajk
2 participants
@jacobwod @Hallbergs