Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sketch: Allow users to select features from other layers #1075

Closed
Tolfx opened this issue May 4, 2022 · 1 comment · Fixed by #1079
Closed

Sketch: Allow users to select features from other layers #1075

Tolfx opened this issue May 4, 2022 · 1 comment · Fixed by #1079
Assignees
@Tolfx
Labels
module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality
Milestone
3.10

Comments

@Tolfx
Copy link
Member

Tolfx commented May 4, 2022

Is your feature request related to a problem? Please describe.
Right now is not possible to select features from layer and copy them, thus adding in sketch a draw method to copy them.
@Tolfx Tolfx added module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality labels May 4, 2022
@Tolfx Tolfx self-assigned this May 4, 2022
Tolfx added a commit that referenced this issue May 4, 2022
@Tolfx
feat: ✨ Added Select on DRAW_TYPES (#1075)
80450bc
Tolfx added a commit that referenced this issue May 4, 2022
@Tolfx
feat: 🚧 Dialog popup on which features to copy (#1075)
c2fa31c
Tolfx added a commit that referenced this issue May 4, 2022
@Tolfx
feat: 🚧 Possible to creature new features on feature layers (#1075)
5fc6324
@Tolfx
Copy link
Member Author

Tolfx commented May 4, 2022

Once copied, it will use the styles and be placed where the feature coordinates where as well, for this screenshot I moved it to show.
image

And if there are multiple layers it will have a pop of which one you would like to copy.
image

Tolfx added a commit that referenced this issue May 4, 2022
@Tolfx
feat: 🎨 Help for select option (#1075)
b548f04
@Tolfx Tolfx added this to the 3.x milestone May 4, 2022
Tolfx added a commit that referenced this issue May 4, 2022
@Tolfx
feat: ✨ Splited into component (#1075)
1740488
Tolfx added a commit that referenced this issue May 4, 2022
@Tolfx
fix: 🐛 Fixed if only one is found popup issue (#1075)
c516d41
@Tolfx Tolfx mentioned this issue May 5, 2022
Merged
@Tolfx Tolfx linked a pull request May 5, 2022 that will close this issue
Plugin(sketch): Copy features/draw layer. #1079
Merged
Hallbergs added a commit that referenced this issue May 6, 2022
@Tolfx @Hallbergs
Plugin(sketch): Copy features/draw layer. (#1079)
70e26fa 
* feat: ✨ Added `Select` on `DRAW_TYPES` (#1075)

* feat: 🚧 Dialog popup on which features to copy (#1075)

* feat: 🚧 Possible to creature new features on feature layers (#1075)

* feat: 🎨 Help for select option (#1075)

* feat: 🚧 Cleanup on `DrawModel`

* feat: ✨ Splited into component (#1075)

* fix: 🐛 Fixed if only one is found popup issue (#1075)

* style: 🎨 Formatting

* Some small changes to sketch-copy. Very WIP!

* Removed unsecure way to extract feature-title in sketch

* Updated some spelling and file-names in sketch

* Cleanup in `SelectFeatureDialog`

* Cleaned up <AddView /> in sketch

* Added some explanations in sketch

* Stop event bubbling in mui dialogs

* Now using real list in <SelectFeatureDialog />

* Now possible to toggle selected features in sketch

* SelectFeaturesDialog now using correct naming

* Added feature highlighting in sketch selection

* feat: 🚧 SketchModel highlight methods

* fix: 🐛 Fixed highlight feature

* feat: ✨ Importing sketchmodel

* feat: ✨ Hightlight methods for sketch select

* fix: 🐛 Fixed on draw features copy

* Added some error-handling in the drawModel

* Added some refinements

* Make sure that everything gets disabled in sketch

* Fix 🔨 DrawModel should only select from the draw-layer

* Refactoring in sketchModel

Co-authored-by: Henrik Hallberg <43059093+Hallbergs@users.noreply.github.com>
@Hallbergs Hallbergs modified the milestones: 3.x, 3.10 May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tolfx Tolfx

Labels
module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality
Projects
None yet
Milestone
3.10
Development

Successfully merging a pull request may close this issue.

Plugin(sketch): Copy features/draw layer. hajkmap/Hajk
3 participants
@jacobwod @Hallbergs @Tolfx