Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmark Removal Confirmation #1155

Closed
OlofSvahnVbg opened this issue Sep 2, 2022 · 1 comment
Closed

Bookmark Removal Confirmation #1155

OlofSvahnVbg opened this issue Sep 2, 2022 · 1 comment
Assignees
@OlofSvahnVbg
Labels
new feature Request for adding/changing functionality
Milestone
3.11

Comments

@OlofSvahnVbg
Copy link
Collaborator

The bookmark delete button should prompt a Confirmation Dialog, hindering the user from deleting a bookmark on accident.

A prompt like this already exists in "Sketch" (SketchRemovalConfirmation), which could be generalized to be used in both the Bookmark and Sketch components, but also in other places.

I suggest creating a generalized Confirmation, adding it to Bookmark and replacing SketchRemovalConfirmation with it in Sketch.

(See preview of finished prompt below)

image
@OlofSvahnVbg OlofSvahnVbg added the new feature Request for adding/changing functionality label Sep 2, 2022
@OlofSvahnVbg OlofSvahnVbg added this to the 3.x milestone Sep 2, 2022
@OlofSvahnVbg OlofSvahnVbg self-assigned this Sep 2, 2022
@Hallbergs
Copy link
Member

Great that you're generalizing!! 🔥

OlofSvahnVbg added a commit that referenced this issue Sep 2, 2022
@OlofSvahnVbg
Added ConfirmationDialog.js and made changes to BookmarkView and Save…
e239e20 
…View. closes #1155
@jesade-vbg jesade-vbg modified the milestones: 3.x, 3.11 Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlofSvahnVbg OlofSvahnVbg

Labels
new feature Request for adding/changing functionality
Projects
None yet
Milestone
3.11
Development

No branches or pull requests
3 participants
@Hallbergs @jesade-vbg @OlofSvahnVbg