Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a secondary label in search results list #1167

Closed
jacobwod opened this issue Sep 8, 2022 · 3 comments
Closed

Show a secondary label in search results list #1167

jacobwod opened this issue Sep 8, 2022 · 3 comments
Assignees
Labels
new feature Request for adding/changing functionality plugin:search Functionality and features of the (core) Search plugin
Milestone

Comments

@jacobwod
Copy link
Member

jacobwod commented Sep 8, 2022

The new MapClickViewer shows more info in the list view by utilising a secondary label (they smaller, gray label below the main label):
Skärmavbild 2022-09-08 kl  13 16 30

When configuring search sources, there is an option to specify a secondary label. Currently it is not shown anywhere in the UI:
Skärmavbild 2022-09-08 kl  13 18 26

The goal of this feature is to implement a similar optional secondary label that shows in search results list.

@jacobwod jacobwod added plugin:search Functionality and features of the (core) Search plugin new feature Request for adding/changing functionality labels Sep 8, 2022
@jacobwod jacobwod added this to the 3.x milestone Sep 8, 2022
@jacobwod jacobwod self-assigned this Sep 8, 2022
@jacobwod
Copy link
Member Author

jacobwod commented Sep 8, 2022

The proposed solution

Before

image

After

Skärmavbild 2022-09-08 kl  13 20 09

Affects only search sources with specified secondary label

It makes no changes to the sources that lack a secondary label. They still display the same way as before:
Skärmavbild 2022-09-08 kl  13 15 09

Results with and without secondary label can be combined

If we combine several search sources (using the selection tool), we end up with a result that looks as expected:
Skärmavbild 2022-09-08 kl  13 14 48

@jacobwod jacobwod modified the milestones: 3.x, 3.11 Sep 8, 2022
@jacobwod
Copy link
Member Author

jacobwod commented Sep 8, 2022

One more addition upcoming: Admin UI needs a new field so we can add this to both WFS sources as well as WMS-as-WFS-sources. This will be new:
image

jacobwod added a commit that referenced this issue Sep 8, 2022
- Added a way to set the 'secondaryLabelFields' in Admin UI for all types of search sources.
@Hallbergs
Copy link
Member

Love it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request for adding/changing functionality plugin:search Functionality and features of the (core) Search plugin
Projects
None yet
Development

No branches or pull requests

2 participants