Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sketch: make it possible to disable the "halo" on text nodes #1186

Closed
jacobwod opened this issue Sep 26, 2022 · 2 comments · Fixed by #1190
Closed

Sketch: make it possible to disable the "halo" on text nodes #1186

jacobwod opened this issue Sep 26, 2022 · 2 comments · Fixed by #1190
Assignees
@Hallbergs
Labels
difficulty:easy Functionality is considered easy to port plugin:draw Functionality and features of the Draw plugin
Milestone
3.11

Comments

@jacobwod
Copy link
Member

jacobwod commented Sep 26, 2022 •
edited
Loading

Currently user must select both foreground and background color when adding text via Sketch.

We should make it possible for users to select "None" for the background, so no halo is generated. There are situations where this is desirable.

A simple fix (selecting the same color for both options) renders a hard-to-read label, so it is unfortunately not an option.

Skärmavbild 2022-09-26 kl 09 11 00
@jacobwod jacobwod added difficulty:easy Functionality is considered easy to port plugin:sketch labels Sep 26, 2022
@jacobwod jacobwod added this to the 3.x milestone Sep 26, 2022
@jacobwod jacobwod added plugin:draw Functionality and features of the Draw plugin and removed plugin:sketch labels Sep 26, 2022
Hallbergs added a commit that referenced this issue Sep 27, 2022
@Hallbergs
Potential fix for #1186
ea33edf
@Hallbergs
Copy link
Member

Just pushed a fix where the halo is removed if the same foreground and background color is chosen. Please try it out, and if it works i'll create a pr.

@Hallbergs Hallbergs self-assigned this Sep 27, 2022
@Hallbergs Hallbergs mentioned this issue Sep 27, 2022
Merged
@Hallbergs Hallbergs linked a pull request Sep 27, 2022 that will close this issue
Potential fix for #1186 #1190
Merged
jacobwod pushed a commit that referenced this issue Sep 27, 2022
@Hallbergs
Potential fix for #1186 (#1190)
6ce539d
@jacobwod
Copy link
Member Author

Just adding a quick show-off:
image

@jacobwod jacobwod modified the milestones: 3.x, 3.11 Sep 28, 2022
@jacobwod jacobwod closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hallbergs Hallbergs

Labels
difficulty:easy Functionality is considered easy to port plugin:draw Functionality and features of the Draw plugin
Projects
None yet
Milestone
3.11
Development

Successfully merging a pull request may close this issue.

Potential fix for #1186 hajkmap/Hajk
2 participants
@jacobwod @Hallbergs