Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Measure tool - step 1 #1243

Closed
jesade-vbg opened this issue Nov 15, 2022 · 7 comments · Fixed by #1292
Closed

New Measure tool - step 1 #1243

jesade-vbg opened this issue Nov 15, 2022 · 7 comments · Fixed by #1292
Assignees
Labels
idea module:client/plugin Functionality that goes into plugins in client needs discussion new feature Request for adding/changing functionality
Milestone

Comments

@jesade-vbg
Copy link
Contributor

I think we should rewrite the measure tool (or probably create a completely new measure tool).
We should also rethink the UI, probably use buttons instead.

There are many other ideas regarding the measure tool in other github issues, but my thoughts is to do this in steps.

So for step 1 the suggestion is (initial thoughts):

  • Rewrite to functional component
  • Use new DrawModel functionality etc
  • Use buttons for the different measurement types
  • Keep the base functionality simple.

I think simplicity is key to keeping this tool a success.

(When I say success, I base it on the usage statistics of the measure tool)

Any thoughts?

@jacobwod
Copy link
Member

I agree with all of the above. We should keep it simple with an absolute minimum of most-used features (which should be determinate by consultation with our users).

There'll still be Sketch for the more advanced use cases.

@Hallbergs
Copy link
Member

I completely agree with everything above!

@jesade-vbg jesade-vbg self-assigned this Dec 2, 2022
@jesade-vbg
Copy link
Contributor Author

jesade-vbg commented Jan 25, 2023

  1. I'm sitting thinking about the ui for the Measure tool. It currently looks like in the screenshot below, but I'm wondering if the buttons should be vertical instead like in the Sketch tool. But in that case the plugin would take more room than needed..... Does anybody have any input on the matter? UI-wise.

image

  1. Naming the plugins is kind of a headache. Currently its called Measure2, but some of us does not like versioning in the name. Any other suggestions?

@jacobwod
Copy link
Member

  1. It looks good to me. If we want to keep it simple we should remove the red "Rensa" button and allow the trash can button to just clear everything off the map (first show an alter asking user "Are you sure you want to remove all measurements?" of course!) In this case I see a really minimalistic UI and it looks good both horizontally and vertically. We could actually have both, using the Grid or Flexbox or whatever. One row if there's room - one column if there's no room for the row.
  2. I took a look at synonyms to the verb "measure". Of those proposed, "meter" looks like the best option to me.
    Skärmavbild 2023-01-25 kl  14 28 39

@Hallbergs
Copy link
Member

Looks good! Maybey "Measurer" could be an option?

@jesade-vbg
Copy link
Contributor Author

jesade-vbg commented Jan 27, 2023

Thanx for input. Regarding Jacobs no1. I think the addition to be able to remove a single measurement is necessary. If you have made alot of measurement and something is wrong you get kind of annoyed that you'll have to do everything again. I also made the hovered object become red if you use the single object delete. So should we keep the added "single delete" feature or remove it? I vote for keep :)

@jacobwod
Copy link
Member

Sound good, keep it! 👍

@jacobwod jacobwod added module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality labels Jan 27, 2023
@jesade-vbg jesade-vbg linked a pull request Feb 23, 2023 that will close this issue
@jesade-vbg jesade-vbg modified the milestones: 3.x, 3.12 Feb 27, 2023
@jacobwod jacobwod closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea module:client/plugin Functionality that goes into plugins in client needs discussion new feature Request for adding/changing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants