Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1243 new measure tool #1292

Merged
merged 19 commits into from
Feb 27, 2023
Merged

Feature/1243 new measure tool #1292

merged 19 commits into from
Feb 27, 2023

Conversation

jesade-vbg
Copy link
Contributor

A long overdue PR.
Closes #1243

@jesade-vbg jesade-vbg added this to the 3.12 milestone Feb 23, 2023
@jesade-vbg jesade-vbg linked an issue Feb 23, 2023 that may be closed by this pull request
New Measure tool - step 1 #1243
Closed
Hallbergs
Hallbergs previously approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@Hallbergs Hallbergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! MeasurerModel is passed to MeasurerView but is not used and can be removed from the props. Maybe the MeasurerModel can be removed since it is barely used ;)

@jacobwod
Minor tweak to add macOS Cmd key support:
0030e8f 
- I had to change the listener from 'keyup' to 'keydown' though, as the e.metaKey only exists on 'keydown', for some reason.
- Please test and verify that this still works as before.
Hallbergs
Hallbergs previously approved these changes Feb 24, 2023
View reviewed changes
jacobwod
jacobwod previously approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@jacobwod jacobwod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Just a small addition for macOS compatibility (the Cmd+Z is customary). Works great for me, good job!

@jesade-vbg jesade-vbg dismissed stale reviews from jacobwod and Hallbergs via f0def8d February 24, 2023 09:05
@jacobwod
Copy link
Member

jacobwod commented Feb 24, 2023 •
edited
Loading

Works fine now regarding the delete interaction.

One last thing I noticed is that the layer is called Draw layer internally - a name that's already taken so we end up with duplicates in the Active layers list (please switch on Show system layers to see them).

Is there a chance that this name can be customised and called something more plugin-specific? Perhaps @Hallbergs knows too?

image

@jesade-vbg
Copy link
Contributor Author

Yes its hardcoded in DrawModel, I will look at it. I have never used the "Active layer" feature so I havnt noticed these things :/

@jesade-vbg
Added possibility to set Layer caption i DrawModel, renamed default c…
b4e69bc 
…aption to 'Draw layer' instead of 'Draw model' and set the Measure tools caption correctly.
@jesade-vbg
Copy link
Contributor Author

jesade-vbg commented Feb 24, 2023 •
edited
Loading

So..... now thats addressed too :) Note that you will get 2 Measure layers if you don't remove the old Measure tool.

@jesade-vbg jesade-vbg merged commit 70edc26 into develop Feb 27, 2023
@jesade-vbg jesade-vbg deleted the feature/1243-new-measure-tool branch February 27, 2023 06:40
@jacobwod jacobwod mentioned this pull request Aug 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hallbergs Hallbergs Hallbergs approved these changes

@jacobwod jacobwod jacobwod left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.12
Development

Successfully merging this pull request may close these issues.

New Measure tool - step 1
3 participants
@jesade-vbg @jacobwod @Hallbergs