Filter roundToDecimals fails parsing string values

[jacobwod]

Describe the bug
This: {GRAY_INDEX|roundToDecimals(2)} will fail if GRAY_INDEX is a string (which it is if it comes from a XML/GML response - only JSON responses have valid JS types).

The reason
I think that this

Hajk/new-client/src/components/FeatureInfo/FeaturePropsFilters.js

Line 133 in 01feb29

return parseFloat(value.toFixed(parseInt(numDecimals))).toLocaleString();

should be this:

return parseFloat(value).toFixed(parseInt(numDecimals)).toLocaleString();

I.e. first parse value, then invoke toFixed(). Currently, we invoke toFixed() on a value that might be a string. I don't think this was intended.

[jesade-vbg]

Actually I think it must be parsed to float again before toLocaleString, if you want toLocaleString to work.

let value = "8.2342"; // can be string or number
let numDecimals = "2"; // can be string or number

parseFloat(parseFloat(value).toFixed(parseInt(numDecimals))).toLocaleString();

[jacobwod]

Or just use the Number construct? It has both toFixed and toLocaleString I'll leave it up to you. 😄