Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/883 layer naming #1094

Merged
merged 26 commits into from
May 30, 2022
Merged

Feature/883 layer naming #1094

merged 26 commits into from
May 30, 2022

Conversation

jacobwod
Copy link
Member

The purpose of this fix to ensure that we have a standard way of identifying what kind of layer an OL layer is, i.e. its intended usage in Hajk.

The main difference is that we go from "custom" (erroneous) solution with layerType being a real property on each ol/layer instance. Instead we now utilise the set/get as intended for ol/layers. So, basically, we go from:

someLayer.layerType => someLayer.get("layerType")

I've ensured to set one of the following values for layerType on each layer:

layer
group
system

Closes #883.

jacobwod added 26 commits May 23, 2022 13:13
@jacobwod
Added a nice table log message to get an overview of our layers
0d7c8c6
@jacobwod
Replaced direct property reads of 'layerType' with .get("layerType").
50eb764
@jacobwod
Fixed MapClickViewer's layer.
12747ba
@jacobwod
Fixed search layers, including VTSearch.
8609a95
@jacobwod
Fixed Sketch's KML and Draw layers.
32f2b3a
@jacobwod
Fixed MapClickModel
ae8a971
@jacobwod
Fixed Infoclick layer
2071f57
@jacobwod
Fixed Buffer's layers.
c296c9f
@jacobwod
FIR & KIR: added the layerType property, did not change caption nor n…
0dae0d0 
…ame though.
@jacobwod
Obsolete FME plugin: added the layerType property, did not change nam…
9a2312d 
…e, did not add caption though.
@jacobwod
Fixed the FME Server plugin's layer.
01d4115
@jacobwod
Fixed plugin GeoSuite's layer.
e191b2e
@jacobwod
Fixed Location plugin.
da45a0e
@jacobwod
Fixed Measure plugin.
61c316d
@jacobwod
VTSearch: added 'layerType' property. Did not add/change 'name' nor '…
503f7e0 
…caption'.
@jacobwod
Fixed Collector plugin.
c23d27d
@jacobwod
Fixed Coordinates plugin.
5908559
@jacobwod
Fixed obsolete Draw plugin.
e82a1da
@jacobwod
Fixed Edit plugin.
ed90b95
@jacobwod
Fixed Print plugin.
e60744d
@jacobwod
Fixed obsolete Export plugin.
bbddf67
@jacobwod
Tried to fix (those part that could be fixed…) Routing plugin.
aec5056
@jacobwod
Fixed StreetView plugin.
867c6e1
@jacobwod
VTSearch: one more small fix.
684ab0d
@jacobwod
Merge branch 'develop' into feature/883-layer-naming
4221408
@jacobwod
Finalizing, removed the temporary log table added in 0d7c8c6.
efe0ed4
@jacobwod jacobwod requested a review from Hallbergs May 30, 2022 13:03
@jacobwod jacobwod linked an issue May 30, 2022 that may be closed by this pull request
Normalise OL Layer's naming inside Hajk #883
Closed
@Hallbergs Hallbergs merged commit f540dc0 into develop May 30, 2022
@Hallbergs Hallbergs deleted the feature/883-layer-naming branch May 30, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hallbergs Hallbergs Hallbergs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalise OL Layer's naming inside Hajk
2 participants
@jacobwod @Hallbergs