Feature/915 custom hdpi #1141
Merged
Feature/915 custom hdpi #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt). Now fetches config from layer-config.
|
Note; No rush with this PR! |
jacobwod
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
I had a look at this and the fact that you have config.useCustomDpiList makes it quite safe to merge for us. (We won't be activating this as we have not run into the issues you solve in this PR - somehow the 90/180 conversion seems to work for the devices I've tested and I always get HIT from GWC.)
Anyway, looks good to me and ready for merge, if you are confident about the actual functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #915
Tested and seems to be working fine with both .Net and Node backend.