Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1160 sketch replace warning #1166

Merged
merged 8 commits into from
Sep 13, 2022

Conversation

OlofSvahnVbg
Copy link
Collaborator

Added a replace warning to SaveView in Sketch that prompts when user types a sketch name that already exists.

@OlofSvahnVbg OlofSvahnVbg added the new feature Request for adding/changing functionality label Sep 8, 2022
@OlofSvahnVbg OlofSvahnVbg added this to the 3.11 milestone Sep 8, 2022
@jesade-vbg
Copy link
Contributor

@Hallbergs Hi, what is going on with the "All checks have failed"? Any idea?

@Hallbergs
Copy link
Member

There is an error with the Hajk version (3.11-dev). Netlify only accepts x.x.x-versions. I thought @jacobwod fixed this in develop. Hmm...

@Hallbergs
Copy link
Member

It should be fixed now. Will take a look at the pr when i get a chance

@Hallbergs
Copy link
Member

Hmm... I saw that some caption-typographys has been changed to spans. Any reason why? Not sure the new look is better? See before and after images:

Before:
image

After:
image

Also, i'm not sure the spacing under the name-input is necessary?
image

@OlofSvahnVbg
Copy link
Collaborator Author

The caption change in the saved skethes list is a mistake, I think. Completely agree it looks better in the before image. The spacing was added so the text would appear more "smoothly" but can be removed easily (inline-block).

@Hallbergs
Copy link
Member

Alright! I see. I think it would look better if the spacing under the input is increased/decreased depending on if the warning text is shown or not! :)

The addition seems to work nicely though! Nice job, will merge when styling is fixed.

@OlofSvahnVbg
Copy link
Collaborator Author

Thanks. I'll make the changes asap.

@OlofSvahnVbg
Copy link
Collaborator Author

Made commit but I found a bug that I'm currently working on.

@jacobwod jacobwod linked an issue Sep 9, 2022 that may be closed by this pull request
@jacobwod jacobwod requested a review from Hallbergs September 9, 2022 06:58
Copy link
Member

@Hallbergs Hallbergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@Hallbergs Hallbergs merged commit 2ee5edb into develop Sep 13, 2022
@Hallbergs Hallbergs deleted the feature/1160-SketchReplaceWarning branch September 13, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request for adding/changing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Warning in Sketch
3 participants