-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1160 sketch replace warning #1166
Conversation
@Hallbergs Hi, what is going on with the "All checks have failed"? Any idea? |
There is an error with the Hajk version (3.11-dev). Netlify only accepts x.x.x-versions. I thought @jacobwod fixed this in develop. Hmm... |
It should be fixed now. Will take a look at the pr when i get a chance |
The caption change in the saved skethes list is a mistake, I think. Completely agree it looks better in the before image. The spacing was added so the text would appear more "smoothly" but can be removed easily (inline-block). |
Alright! I see. I think it would look better if the spacing under the input is increased/decreased depending on if the warning text is shown or not! :) The addition seems to work nicely though! Nice job, will merge when styling is fixed. |
Thanks. I'll make the changes asap. |
…p/Hajk into feature/1160-SketchReplaceWarning
Made commit but I found a bug that I'm currently working on. |
…avoid re-render loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Added a replace warning to SaveView in Sketch that prompts when user types a sketch name that already exists.