Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1093 new dummy plugin #1173

Merged
merged 15 commits into from
Sep 14, 2022
Merged

Feature/1093 new dummy plugin #1173

merged 15 commits into from
Sep 14, 2022

Conversation

Hallbergs
Copy link
Member

@Hallbergs Hallbergs commented Sep 14, 2022 •
edited by jesade-vbg
Loading

Updated Dummy-plugin based on functional components.

Includes:

  • Lots of information and tips
  • Updating local-storage (also making sure we're allowed to)
  • Using core models
  • and more...

Hallbergs and others added 15 commits May 31, 2022 09:38
@Hallbergs
Could not get Dummy to render the drawer... State-update timing issue…
a70e40b 
…s? (Fixed)
@Hallbergs
DummyView now FC. WIP!
85e952f
@Hallbergs
Added explanations regarding the useEffect-, useState-, and useCallba…
d6d743d 
…ck-hooks
@Hallbergs
Dummy.js now FC. More explanations added
f319847
@jacobwod
Rephrased some sentences in the comments.
d474208
@jacobwod
More rephrasing in the comments.
9f035f6
@Hallbergs
Merge remote-tracking branch 'origin/develop' into feature/1093-new-d…
6cd66f7 
…ummy-plugin
@Hallbergs
The random hex-color generator could generate invalid codes
aa93624
@Hallbergs
Some additions to the dummy-model
8b80341
@Hallbergs
Merge remote-tracking branch 'origin/develop' into feature/1093-new-d…
67bc07a 
…ummy-plugin
@Hallbergs
Added drawModel to dummy
9e9696f
@Hallbergs
Simplified initiation of drawModel
7659f5b
@Hallbergs
Added toggling of drawModel in dummy
70b60b0
@Hallbergs
Added clarifying comments
5d61c21
@Hallbergs
Now using LS in dummy for illustration
7fcbd4b
@Hallbergs Hallbergs added the module:client/plugin Functionality that goes into plugins in client label Sep 14, 2022
@Hallbergs Hallbergs self-assigned this Sep 14, 2022
jesade-vbg
jesade-vbg approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@jesade-vbg jesade-vbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really awesome! Should help alot, both to get coders to produce and to get them to make it right (follow best practice). I also like the Object.freeze (dont mess with this stuff) :)

jacobwod
jacobwod approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@jacobwod jacobwod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@jacobwod jacobwod merged commit 5ad6502 into develop Sep 14, 2022
@jacobwod jacobwod deleted the feature/1093-new-dummy-plugin branch September 14, 2022 09:51
@Hallbergs Hallbergs linked an issue Sep 15, 2022 that may be closed by this pull request
Create a new Dummy-plugin #1093
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesade-vbg jesade-vbg jesade-vbg approved these changes

@jacobwod jacobwod jacobwod approved these changes

Assignees

@Hallbergs Hallbergs

Labels
module:client/plugin Functionality that goes into plugins in client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a new Dummy-plugin
3 participants
@Hallbergs @jacobwod @jesade-vbg