Added functionality for adding frame around image in admin

[OlofSvahnVbg]

You can now select in admin to add a dark gray frame around the map image in the pdf. The option to add frame is only available there, and not for the user.

[jacobwod]

Nice!

Just one more thing: I don't want to be picky, but how does the frame affect the print area? I.e., when the frame is visible, do we reflect that in print preview (the "orange rectangle" that user can move around and select what will be printed).

I know that this is just a minor addition but when you zoom in close enough, the width of the frame can affect the viewport substantially. We've had users complaining about "Print does not print exactly what I selected!" before… 😄

[OlofSvahnVbg]

Good point. I'll check on it.

[OlofSvahnVbg]

[OlofSvahnVbg]

The frame doesnt seem to obscure any map area, not that I can see at least. What do you think?

[jacobwod]

It should, I think… :) Unless you've enabled useMargin in options, of course. That way the frame will end up inside the margin and not affect the map. But if useMargin is false, the frame should obstruct some part of the map?

[OlofSvahnVbg]

Ok, so I added border to image without margins and reworked a segment of code to a if-tree (not my best work but I think it's easier to read now). This seems to work, the border does not obscure the map image when choosing any scale or margin size.

[jacobwod]

Looks good @OlofSvahnVbg, it seems like you need to merge in develop as there's one conflict in PrintModel currently. 👍

[jacobwod]

Just wondering if you and @jesade-vbg already had a look at this together, or if we should await @jesade-vbg's review?