Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1267 refactor bookmarks plugin #1270

Merged
merged 19 commits into from
Feb 3, 2023
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 72 additions & 45 deletions new-client/src/plugins/Bookmarks/Bookmarks.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import PropTypes from "prop-types";
import BaseWindowPlugin from "../BaseWindowPlugin";
import BookmarksModel from "./BookmarksModel";
import BookmarksView from "./BookmarksView";
import Observer from "react-event-observer";
import BookmarksIcon from "@mui/icons-material/Bookmarks";

/**
Expand All @@ -11,58 +12,84 @@ import BookmarksIcon from "@mui/icons-material/Bookmarks";
* in localStorage. A bookmark contains the map, x,y, zoom level, visible layers etc.
*
* @class Bookmarks
* @extends {React.PureComponent}
* @extends {React.Component}
*/
class Bookmarks extends React.PureComponent {
state = {
title: "Bokmärken",
color: null,
};

static propTypes = {
app: PropTypes.object.isRequired,
map: PropTypes.object.isRequired,
options: PropTypes.object.isRequired,
const Bookmarks = (props) => {
const [state, setState] = React.useState({ title: "Bokmärken", color: null });
const [pluginShown, setPluginShown] = React.useState(
props.options.visibleAtStart ?? false
);
const [localObserver] = React.useState(Observer());
const [bookmarksModel] = React.useState(
() =>
new BookmarksModel({
app: props.app,
map: props.map,
})
);
const [bookmarks, setBookmarks] = React.useState(bookmarksModel.bookmarks);

// Read bookmarks from local storage on component mount
React.useEffect(() => {
bookmarksModel.readFromStorage();
setBookmarks(bookmarksModel.bookmarks);
}, [bookmarksModel]);

// Listen for updates to bookmarks in local storage
React.useEffect(() => {
const updateBookmarks = () => {
bookmarksModel.readFromStorage();
setBookmarks(bookmarksModel.bookmarks);
};
window.addEventListener("storage", updateBookmarks);
return () => window.removeEventListener("storage", updateBookmarks);
}, [bookmarksModel]);

// Called when the plugin is hidden
const onWindowHide = () => {
setPluginShown(false);
};

static defaultProps = {
options: {},
// Called when the plugin is shown
const onWindowShow = () => {
setPluginShown(true);
};

constructor(props) {
super(props);
this.bookmarksModel = new BookmarksModel({
app: props.app,
map: props.map,
});
}
return (
<BaseWindowPlugin
{...props}
type="Bookmarks"
custom={{
icon: <BookmarksIcon />,
title: state.title,
color: state.color,
description: "Användarens bokmärken",
height: 450,
width: 400,
onWindowHide: onWindowHide,
onWindowShow: onWindowShow,
}}
>
<BookmarksView
model={bookmarksModel}
bookmarks={bookmarks}
app={props.app}
localObserver={localObserver}
globalObserver={props.app.globalObserver}
/>
</BaseWindowPlugin>
);
};

updateCustomProp = (prop, value) => {
this.setState({ [prop]: value });
};
Bookmarks.propTypes = {
app: PropTypes.object.isRequired,
map: PropTypes.object.isRequired,
options: PropTypes.object,
};

render() {
return (
<BaseWindowPlugin
{...this.props}
type="Bookmarks"
custom={{
icon: <BookmarksIcon />,
title: this.state.title,
color: this.state.color,
description: "Användarens bokmärken",
height: 450,
width: 400,
}}
>
<BookmarksView
model={this.bookmarksModel}
app={this.props.app}
updateCustomProp={this.updateCustomProp}
/>
</BaseWindowPlugin>
);
}
}
Bookmarks.defaultProps = {
options: {},
};

export default Bookmarks;
4 changes: 4 additions & 0 deletions new-client/src/plugins/Bookmarks/BookmarksModel.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,10 @@ class BookmarksModel {
this.writeToStorage();
}
}

getBookmarks() {
return this.bookmarks;
}
}

export default BookmarksModel;
Loading