-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A first step towards implementing RFC 1 and 2 #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is functionality on and off.
…in. This will aid anyone wanting to adapt it into their own setup.
…om more than 1 property are disallowed. Also, marker feature is added only for the property layer, not digital plans layer.
…lansReport is false.
…d layers. Closes #1451.
Hallbergs
previously approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm in my environment!
Hallbergs
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes, including:
dokumentation
andproxy
directories)For motivation, refer to documents located in
docs/rfcs
.Important note for tester
Ensure to review changes in Hajk's main configuration files (Client's
appConfig.json
, Backend's.env
and Admin'sconfig.json
). There are added/removed keys that control new/deprecated functionality. Failing to set them may lead to unexpected behaviour.The recommended workflow is the typical one: stash your changes, checkout this branch and apply your stashed changes. Fix any merge conflicts.