Feature/1358 copy coordinates #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Netlify fails since the repo structure is updated in develop but not in master. Nothing to worry about. We should set up separate builds for develop and master tbh. |
|
We're going to test some more, so now in Draft mode. |
jesade-vbg
requested changes
May 8, 2024
Hallbergs
reviewed
May 15, 2024
| // Make the element non-interactive and hide it | ||
| input.setAttribute("readonly", ""); | ||
| input.style.position = "absolute"; | ||
| input.style.left = "-9999px"; |
There was a problem hiding this comment.
Instead of creating an element to copy from, wouldn't navigator.clipboard.writeText(coordinatesString) get the job done? There might be security considerations that i am missing though.
jesade-vbg
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1358