Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ''' from example Python code #125

Closed
wants to merge 1 commit into from
Closed

Conversation

clayote
Copy link

@clayote clayote commented Feb 19, 2018

I think these were leftover from when the docs were in Markdown? As-is, they mean the code samples don't run properly.

I think these were leftover from when the docs were in Markdown?
@clayote clayote changed the title Remove ''' from Python code Remove ''' from example Python code Feb 19, 2018
@codecov
Copy link

codecov bot commented Feb 19, 2018

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   73.87%   73.87%           
=======================================
  Files           3        3           
  Lines         888      888           
=======================================
  Hits          656      656           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d98a354...bac8d1c. Read the comment docs.

@halcy
Copy link
Owner

halcy commented Feb 20, 2018

The commenting-out is there on purpose, to make sure somebody does not just copy-paste the code without any consideration and creates a script that registers a new app every time it runs (those stay in the database forever, which is Not Great). For the login, I'd be fine with taking them out, but for app registration, I'm strongly for leaving them in there.

@clayote clayote closed this Feb 22, 2018
MarkEEaton added a commit to MarkEEaton/Mastodon.py that referenced this pull request Aug 14, 2018
This commit takes into account the discussion from halcy#125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants