Skip to content

update bronto naming and usage. tests still breaking #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: synonym-generation
Choose a base branch
from
Open

update bronto naming and usage. tests still breaking #1

wants to merge 1 commit into from

Conversation

adelevie
Copy link

Hi, @hale, I want to get the ball rolling here if you're free.

Tests are still breaking, and I'm a bit unfamiliar with the underlying structure of the code, so perhaps a quick run through by you might make things easier. Here are the errors I'm currently getting:

➜  rails_nlp git:(synonym-generation) rake spec
/Users/alandelevie/.rvm/rubies/ruby-2.1.1/bin/ruby -S rspec ./spec/rails_nlp/keyword_spec.rb ./spec/rails_nlp/query_spec.rb ./spec/rails_nlp/spell_checker_spec.rb ./spec/rails_nlp/text_analyser_spec.rb ./spec/rails_nlp_spec.rb
I, [2014-06-13T15:18:27.161664 #7163]  INFO -- : Not reporting to Code Climate because ENV['CODECLIMATE_REPO_TOKEN'] is not set.
[deprecated] I18n.enforce_available_locales will default to true in the future. If you really want to skip validation of your locale you can set I18n.enforce_available_locales = false to avoid this message.
.......FF.......SEQUEL DEPRECATION WARNING: Symbol#as is deprecated and will be removed in Sequel 4.0.  Please use Sequel.as instead, or Sequel.extension(:core_extensions) to continue using it.
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/sequel-3.48.0/lib/sequel/deprecated.rb:67:in `block (3 levels) in deprecated_module'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:300:in `block in execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `map'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:214:in `perform_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:111:in `calculate'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:26:in `count'
/Users/alandelevie/uscis/rails_nlp/lib/rails_nlp.rb:62:in `suggest_stopwords'
/Users/alandelevie/uscis/rails_nlp/spec/rails_nlp_spec.rb:42:in `block (3 levels) in <module:RailsNlp>'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/rspec-core-2.14.8/lib/rspec/core/example.rb:114:in `instance_eval'
FSEQUEL DEPRECATION WARNING: Symbol#as is deprecated and will be removed in Sequel 4.0.  Please use Sequel.as instead, or Sequel.extension(:core_extensions) to continue using it.
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/sequel-3.48.0/lib/sequel/deprecated.rb:67:in `block (3 levels) in deprecated_module'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:300:in `block in execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `map'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:214:in `perform_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:111:in `calculate'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:26:in `count'
/Users/alandelevie/uscis/rails_nlp/lib/rails_nlp.rb:62:in `suggest_stopwords'
/Users/alandelevie/uscis/rails_nlp/spec/rails_nlp_spec.rb:50:in `block (3 levels) in <module:RailsNlp>'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/rspec-core-2.14.8/lib/rspec/core/example.rb:114:in `instance_eval'
FSEQUEL DEPRECATION WARNING: Symbol#as is deprecated and will be removed in Sequel 4.0.  Please use Sequel.as instead, or Sequel.extension(:core_extensions) to continue using it.
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/sequel-3.48.0/lib/sequel/deprecated.rb:67:in `block (3 levels) in deprecated_module'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:300:in `block in execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `map'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:214:in `perform_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:111:in `calculate'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:26:in `count'
/Users/alandelevie/uscis/rails_nlp/lib/rails_nlp.rb:62:in `suggest_stopwords'
/Users/alandelevie/uscis/rails_nlp/spec/rails_nlp_spec.rb:22:in `block (3 levels) in <module:RailsNlp>'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/rspec-core-2.14.8/lib/rspec/core/example.rb:114:in `instance_eval'
FSEQUEL DEPRECATION WARNING: Symbol#as is deprecated and will be removed in Sequel 4.0.  Please use Sequel.as instead, or Sequel.extension(:core_extensions) to continue using it.
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/sequel-3.48.0/lib/sequel/deprecated.rb:67:in `block (3 levels) in deprecated_module'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:300:in `block in execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `map'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:214:in `perform_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:111:in `calculate'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:26:in `count'
/Users/alandelevie/uscis/rails_nlp/lib/rails_nlp.rb:62:in `suggest_stopwords'
/Users/alandelevie/uscis/rails_nlp/spec/rails_nlp_spec.rb:34:in `block (3 levels) in <module:RailsNlp>'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/rspec-core-2.14.8/lib/rspec/core/example.rb:114:in `instance_eval'
FSEQUEL DEPRECATION WARNING: Symbol#as is deprecated and will be removed in Sequel 4.0.  Please use Sequel.as instead, or Sequel.extension(:core_extensions) to continue using it.
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/sequel-3.48.0/lib/sequel/deprecated.rb:67:in `block (3 levels) in deprecated_module'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:300:in `block in execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `map'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:214:in `perform_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:111:in `calculate'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:26:in `count'
/Users/alandelevie/uscis/rails_nlp/lib/rails_nlp.rb:62:in `suggest_stopwords'
/Users/alandelevie/uscis/rails_nlp/spec/rails_nlp_spec.rb:27:in `block (3 levels) in <module:RailsNlp>'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/rspec-core-2.14.8/lib/rspec/core/example.rb:114:in `instance_eval'
FSEQUEL DEPRECATION WARNING: Symbol#as is deprecated and will be removed in Sequel 4.0.  Please use Sequel.as instead, or Sequel.extension(:core_extensions) to continue using it.
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/sequel-3.48.0/lib/sequel/deprecated.rb:67:in `block (3 levels) in deprecated_module'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:300:in `block in execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `map'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:214:in `perform_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:111:in `calculate'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:26:in `count'
/Users/alandelevie/uscis/rails_nlp/lib/rails_nlp.rb:62:in `suggest_stopwords'
/Users/alandelevie/uscis/rails_nlp/spec/rails_nlp_spec.rb:58:in `block (3 levels) in <module:RailsNlp>'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/rspec-core-2.14.8/lib/rspec/core/example.rb:114:in `instance_eval'
FSEQUEL DEPRECATION WARNING: Symbol#as is deprecated and will be removed in Sequel 4.0.  Please use Sequel.as instead, or Sequel.extension(:core_extensions) to continue using it.
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/sequel-3.48.0/lib/sequel/deprecated.rb:67:in `block (3 levels) in deprecated_module'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:300:in `block in execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `map'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:214:in `perform_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:111:in `calculate'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:26:in `count'
/Users/alandelevie/uscis/rails_nlp/lib/rails_nlp.rb:62:in `suggest_stopwords'
/Users/alandelevie/uscis/rails_nlp/spec/rails_nlp_spec.rb:66:in `block (3 levels) in <module:RailsNlp>'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/rspec-core-2.14.8/lib/rspec/core/example.rb:114:in `instance_eval'
F............................SEQUEL DEPRECATION WARNING: Symbol#as is deprecated and will be removed in Sequel 4.0.  Please use Sequel.as instead, or Sequel.extension(:core_extensions) to continue using it.
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/sequel-3.48.0/lib/sequel/deprecated.rb:67:in `block (3 levels) in deprecated_module'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:300:in `block in execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `map'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:214:in `perform_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:111:in `calculate'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:26:in `count'
/Users/alandelevie/uscis/rails_nlp/lib/rails_nlp.rb:62:in `suggest_stopwords'
/Users/alandelevie/uscis/rails_nlp/lib/rails_nlp/query.rb:15:in `keywords'
/Users/alandelevie/uscis/rails_nlp/lib/rails_nlp/query.rb:28:in `block in stems'
F..SEQUEL DEPRECATION WARNING: Symbol#as is deprecated and will be removed in Sequel 4.0.  Please use Sequel.as instead, or Sequel.extension(:core_extensions) to continue using it.
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/sequel-3.48.0/lib/sequel/deprecated.rb:67:in `block (3 levels) in deprecated_module'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:300:in `block in execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `map'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:298:in `execute_grouped_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:214:in `perform_calculation'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:111:in `calculate'
/Users/alandelevie/.rvm/gems/ruby-2.1.1/gems/activerecord-4.1.1/lib/active_record/relation/calculations.rb:26:in `count'
/Users/alandelevie/uscis/rails_nlp/lib/rails_nlp.rb:62:in `suggest_stopwords'
/Users/alandelevie/uscis/rails_nlp/lib/rails_nlp/query.rb:15:in `keywords'
/Users/alandelevie/uscis/rails_nlp/lib/rails_nlp/query.rb:20:in `block in metaphones'
F....

Failures:

  1) RailsNlp::Keyword analysis of keywords before save synonym generation sets the #synonyms to be an array of synonyms
     Failure/Error: expect(kw.synonyms).to eq(%w(adult\ female adult\ male barf cast chuck))

       expected: ["adult female", "adult male", "barf", "cast", "chuck"]
            got: {:noun=>{:syn=>["adult female", "adult male", "african tea", "arabian tea", "big cat", "bozo", "cat-o'-nine-tails", "caterpillar", "computed axial tomography", "computed tomography", "computerized axial tomography", "computerized tomography", "ct", "excitant", "felid", "feline", "gossip", "gossiper", "gossipmonger", "guy", "hombre", "kat", "khat", "man", "newsmonger", "qat", "quat", "rumormonger", "rumourmonger", "stimulant", "stimulant drug", "tracked vehicle", "true cat", "whip", "woman", "x-radiation", "x-raying"]}, :verb=>{:syn=>["barf", "be sick", "cast", "chuck", "disgorge", "egest", "eliminate", "excrete", "flog", "honk", "lash", "lather", "pass", "puke", "purge", "regorge", "regurgitate", "retch", "sick", "slash", "spew", "spue", "strap", "throw up", "trounce", "upchuck", "vomit", "vomit up", "welt", "whip"]}}

       (compared using ==)

       Diff:
       @@ -1,2 +1,3 @@
       -["adult female", "adult male", "barf", "cast", "chuck"]
       +:noun => {:syn=>["adult female", "adult male", "african tea", "arabian tea", "big cat", "bozo", "cat-o'-nine-tails", "caterpillar", "computed axial tomography", "computed tomography", "computerized axial tomography", "computerized tomography", "ct", "excitant", "felid", "feline", "gossip", "gossiper", "gossipmonger", "guy", "hombre", "kat", "khat", "man", "newsmonger", "qat", "quat", "rumormonger", "rumourmonger", "stimulant", "stimulant drug", "tracked vehicle", "true cat", "whip", "woman", "x-radiation", "x-raying"]},
       +:verb => {:syn=>["barf", "be sick", "cast", "chuck", "disgorge", "egest", "eliminate", "excrete", "flog", "honk", "lash", "lather", "pass", "puke", "purge", "regorge", "regurgitate", "retch", "sick", "slash", "spew", "spue", "strap", "throw up", "trounce", "upchuck", "vomit", "vomit up", "welt", "whip"]}
     # ./spec/rails_nlp/keyword_spec.rb:51:in `block (4 levels) in <module:RailsNlp>'

  2) RailsNlp::Keyword analysis of keywords before save synonym generation changes the #synonyms field
     Failure/Error: expect(kw.synonyms.class).to eq(Array)

       expected: Array
            got: Hash

       (compared using ==)

       Diff:
       @@ -1,2 +1,2 @@
       -Array
       +Hash
     # ./spec/rails_nlp/keyword_spec.rb:41:in `block (4 levels) in <module:RailsNlp>'

  3) RailsNlp self.suggest_stopwords never includes blacklisted words
     Failure/Error: expect(RailsNlp.suggest_stopwords).to_not include("house")
     ArgumentError:
       wrong number of arguments (0 for 1)
     # ./lib/rails_nlp.rb:62:in `suggest_stopwords'
     # ./spec/rails_nlp_spec.rb:42:in `block (3 levels) in <module:RailsNlp>'

  4) RailsNlp self.suggest_stopwords whitelist takes priority over blacklist
     Failure/Error: expect(RailsNlp.suggest_stopwords).to include("house")
     ArgumentError:
       wrong number of arguments (0 for 1)
     # ./lib/rails_nlp.rb:62:in `suggest_stopwords'
     # ./spec/rails_nlp_spec.rb:50:in `block (3 levels) in <module:RailsNlp>'

  5) RailsNlp self.suggest_stopwords gives most common words across all records
     Failure/Error: expect(RailsNlp.suggest_stopwords(n: 1)).to eq(["duped"])
     ArgumentError:
       wrong number of arguments (0 for 1)
     # ./lib/rails_nlp.rb:62:in `suggest_stopwords'
     # ./spec/rails_nlp_spec.rb:22:in `block (3 levels) in <module:RailsNlp>'

  6) RailsNlp self.suggest_stopwords always suggests whitelisted words
     Failure/Error: expect(RailsNlp.suggest_stopwords).to include("horse")
     ArgumentError:
       wrong number of arguments (0 for 1)
     # ./lib/rails_nlp.rb:62:in `suggest_stopwords'
     # ./spec/rails_nlp_spec.rb:34:in `block (3 levels) in <module:RailsNlp>'

  7) RailsNlp self.suggest_stopwords stopwords are returned when amount requested is too large
     Failure/Error: expect(RailsNlp.suggest_stopwords(n: 100)).to_not be_nil
     ArgumentError:
       wrong number of arguments (0 for 1)
     # ./lib/rails_nlp.rb:62:in `suggest_stopwords'
     # ./spec/rails_nlp_spec.rb:27:in `block (3 levels) in <module:RailsNlp>'

  8) RailsNlp self.suggest_stopwords by default number of stopwords is 10% of Keyword.count
     Failure/Error: expect(RailsNlp.suggest_stopwords.size).to eq(2)
     ArgumentError:
       wrong number of arguments (0 for 1)
     # ./lib/rails_nlp.rb:62:in `suggest_stopwords'
     # ./spec/rails_nlp_spec.rb:58:in `block (3 levels) in <module:RailsNlp>'

  9) RailsNlp self.suggest_stopwords can set a max number of stopwords
     Failure/Error: expect(RailsNlp.suggest_stopwords(n_max: 1).size).to eq(1)
     ArgumentError:
       wrong number of arguments (0 for 1)
     # ./lib/rails_nlp.rb:62:in `suggest_stopwords'
     # ./spec/rails_nlp_spec.rb:66:in `block (3 levels) in <module:RailsNlp>'

  10) RailsNlp::Query #stems gives the stems of the keywords
     Failure/Error: expect(q.stems).to eq("switch bar")
     ArgumentError:
       wrong number of arguments (0 for 1)
     # ./lib/rails_nlp.rb:62:in `suggest_stopwords'
     # ./lib/rails_nlp/query.rb:15:in `keywords'
     # ./lib/rails_nlp/query.rb:28:in `block in stems'
     # ./lib/rails_nlp/query.rb:27:in `tap'
     # ./lib/rails_nlp/query.rb:27:in `stems'
     # ./spec/rails_nlp/query_spec.rb:23:in `block (2 levels) in <module:RailsNlp>'

  11) RailsNlp::Query #metaphones gives the keywords converted to metaphones
     Failure/Error: expect(q.metaphones).to eq("PJR HL")
     ArgumentError:
       wrong number of arguments (0 for 1)
     # ./lib/rails_nlp.rb:62:in `suggest_stopwords'
     # ./lib/rails_nlp/query.rb:15:in `keywords'
     # ./lib/rails_nlp/query.rb:20:in `block in metaphones'
     # ./lib/rails_nlp/query.rb:19:in `tap'
     # ./lib/rails_nlp/query.rb:19:in `metaphones'
     # ./spec/rails_nlp/query_spec.rb:18:in `block (2 levels) in <module:RailsNlp>'

Finished in 52.34 seconds
59 examples, 11 failures

Failed examples:

rspec ./spec/rails_nlp/keyword_spec.rb:44 # RailsNlp::Keyword analysis of keywords before save synonym generation sets the #synonyms to be an array of synonyms
rspec ./spec/rails_nlp/keyword_spec.rb:39 # RailsNlp::Keyword analysis of keywords before save synonym generation changes the #synonyms field
rspec ./spec/rails_nlp_spec.rb:37 # RailsNlp self.suggest_stopwords never includes blacklisted words
rspec ./spec/rails_nlp_spec.rb:45 # RailsNlp self.suggest_stopwords whitelist takes priority over blacklist
rspec ./spec/rails_nlp_spec.rb:19 # RailsNlp self.suggest_stopwords gives most common words across all records
rspec ./spec/rails_nlp_spec.rb:30 # RailsNlp self.suggest_stopwords always suggests whitelisted words
rspec ./spec/rails_nlp_spec.rb:25 # RailsNlp self.suggest_stopwords stopwords are returned when amount requested is too large
rspec ./spec/rails_nlp_spec.rb:53 # RailsNlp self.suggest_stopwords by default number of stopwords is 10% of Keyword.count
rspec ./spec/rails_nlp_spec.rb:61 # RailsNlp self.suggest_stopwords can set a max number of stopwords
rspec ./spec/rails_nlp/query_spec.rb:21 # RailsNlp::Query #stems gives the stems of the keywords
rspec ./spec/rails_nlp/query_spec.rb:16 # RailsNlp::Query #metaphones gives the keywords converted to metaphones

Randomized with seed 32806

/Users/alandelevie/.rvm/rubies/ruby-2.1.1/bin/ruby -S rspec ./spec/rails_nlp/keyword_spec.rb ./spec/rails_nlp/query_spec.rb ./spec/rails_nlp/spell_checker_spec.rb ./spec/rails_nlp/text_analyser_spec.rb ./spec/rails_nlp_spec.rb failed

@amoose
Copy link

amoose commented Jun 16, 2014

I'm seeing that the Rakefile does not match the gemspec for the Rspec dependencies

I added gem 'rspec', '~> 3.0' to the Rakefile and the tests passed without issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adelevie @amoose