-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add quotes to automatically generated condition contexts on parent #1184
Conversation
hale studio builds for this pull request: Build triggered for commit c34f6b1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for the link to the issue showing up properly in the changelog the reference needs to be prefixed with "closes" or "fixes".
e.g. Closes #1104
@stempler Do you mean in the commit message or in the here in the PR description? My reasoning for not adding a |
@florianesser Not 100% sure, I think it should be at least in the commit. We disussed that recently (see here). I think preferable would be if the PR is merged after the issue is challenged, which ideally can be done with the artifacts provided in the PR. What do you think? |
From what I know the keywords that can be used are the following:
These can be added as well to our "Developer Guidelines". |
Ok, I see, I'll add the keyword. I'll just have to remember not to merge directly after approval of the PR anymore :) |
f21b7dc
to
69be03b
Compare
69be03b
to
05168e2
Compare
Might be a nice enhancement to add a comment with the build artifacts directly to the referenced issue as well. Or was that not done on purpose? |
Do you mean when the PR is merged? semantic-release will add a link to the GitHub release (see example here), and the artifacts there are available permanently. The artifacts for the PR are only available temporarily, and may be updated. |
See here for what is supported by default by the release process. |
No, I meant when the PR artifacts are built so that the challenger can see them directly in the issue (I now mentioned them manually there), but...
that explains it. As the PR is referenced anyway if one of the "Closes" keywords is used, I don't think it's necessary to put effort into an automatic comment. |
When generating a condition context on a parent for a property with a name that has special meaning in CQL (like `id`), the generated filter does not work as expected. With this change, the property name is put in quotes so that filters with special property names work correctly. Closes #1104
05168e2
to
e520af3
Compare
Implementation was challenged by Johanna, will merge as soon as the checks are done. |
🎉 This PR is included in version 5.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
When generating a condition context on a parent for a property with a name that has special meaning in CQL (like
id
), the generated filter does not work as expected. With this change, the property name is put in quotes so that filters with special property names work correctly.Closes #1104