fix: add quotes to automatically generated condition contexts on parent

[florianesser]

When generating a condition context on a parent for a property with a name that has special meaning in CQL (like id), the generated filter does not work as expected. With this change, the property name is put in quotes so that filters with special property names work correctly.

Closes #1104

[github-actions]

hale studio builds for this pull request:

• Linux x64
• Windows x64
• macos x64

Build triggered for commit c34f6b1.
Artifacts are retained for 14 days.

[stempler]

I think for the link to the issue showing up properly in the changelog the reference needs to be prefixed with "closes" or "fixes".

e.g. Closes #1104

[florianesser]

I think for the link to the issue showing up properly in the changelog the reference needs to be prefixed with "closes" or "fixes".

@stempler Do you mean in the commit message or in the here in the PR description?

My reasoning for not adding a closes reference was to avoid that GitHub closes the issue automatically as soon as the PR is merged. If we're ok with that, I'm happy to add it.

[stempler]

@florianesser Not 100% sure, I think it should be at least in the commit. We disussed that recently (see here). I think preferable would be if the PR is merged after the issue is challenged, which ideally can be done with the artifacts provided in the PR. What do you think?

[emanuelaepure10]

From what I know the keywords that can be used are the following:

• Closes #issue_number
• Fixes #issue_number
• Resolves #issue_number

These can be added as well to our "Developer Guidelines".

[florianesser]

I think preferable would be if the PR is merged after the issue is challenged, which ideally can be done with the artifacts provided in the PR. What do you think?

Ok, I see, I'll add the keyword. I'll just have to remember not to merge directly after approval of the PR anymore :)

[florianesser]

Might be a nice enhancement to add a comment with the build artifacts directly to the referenced issue as well. Or was that not done on purpose?

[stempler]

Might be a nice enhancement to add a comment with the build artifacts directly to the referenced issue as well. Or was that not done on purpose?

Do you mean when the PR is merged?

semantic-release will add a link to the GitHub release (see example here), and the artifacts there are available permanently.

The artifacts for the PR are only available temporarily, and may be updated.
For adding a comment to the issue we would also need some logic to determine the issue, not sure if that's easily done.

[stempler]

From what I know the keywords that can be used are the following:

See here for what is supported by default by the release process.

[florianesser]

Do you mean when the PR is merged?

No, I meant when the PR artifacts are built so that the challenger can see them directly in the issue (I now mentioned them manually there), but...

For adding a comment to the issue we would also need some logic to determine the issue, not sure if that's easily done.

that explains it. As the PR is referenced anyway if one of the "Closes" keywords is used, I don't think it's necessary to put effort into an automatic comment.

[florianesser]

Implementation was challenged by Johanna, will merge as soon as the checks are done.

[we-release]

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

• v5.2.0
• GitHub release

Your semantic-release bot 📦🚀