Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

chore: bump uppy version to fix crash on chrome browser #900

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 8, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

修复在非安全情况下(非 HTTPS 环境或本地环境),在 Chromium 内核的浏览器下拖拽文件上传出现浏览器崩溃的问题。

修复来源:

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3017

Screenshots:

before:

2023-03-08 10 59 02

after:

2023-03-08 11 00 06

Special notes for your reviewer:

测试方式:

  1. 需要先执行 make -C console install 以更新 Console 的依赖。
  2. 使用非 localhost 或者 127.0.0.1 访问 Halo 后台,本地环境可以使用 192.168.x.x 访问。
  3. 在 Console 的附件管理测试拖拽文件上传,观察浏览器是否崩溃。

Does this PR introduce a user-facing change?

修复非 HTTPS 环境下,在 Chromium 内核浏览器拖拽上传文件时出现浏览器崩溃的问题。

@vercel
Copy link

vercel bot commented Mar 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 8, 2023 at 1:38PM (UTC)

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Mar 8, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and QuentinHsu March 8, 2023 13:37
@ruibaby ruibaby added this to the 2.3.1 milestone Mar 8, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

See halo-dev/halo#3481 for more.

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 9c5b3d7 into halo-dev:release-2.3 Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants