Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add theme design #14

Merged
merged 5 commits into from
Jul 18, 2022
Merged

feat: add theme design #14

merged 5 commits into from
Jul 18, 2022

Conversation

guqing
Copy link
Member

@guqing guqing commented Jul 4, 2022 •
edited by JohnNiang
Loading

What this PR does?

新增主题设计

新增主题设计

/cc @halo-dev/sig-docs

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 4, 2022
@guqing guqing changed the title feat: add theme design [WIP] feat: add theme design Jul 4, 2022
@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 4, 2022
@guqing guqing changed the title [WIP] feat: add theme design feat: add theme design Jul 6, 2022
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2022
@guqing
Copy link
Member Author

guqing commented Jul 6, 2022

/cc @halo-dev/sig-halo

wan92hen
wan92hen reviewed Jul 6, 2022
View reviewed changes
theme/README.md Outdated Show resolved Hide resolved
theme/README.md Outdated Show resolved Hide resolved
theme/README.md Outdated Show resolved Hide resolved
@guqing
Copy link
Member Author

guqing commented Jul 12, 2022

/hold until #17 merged

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2022
JohnNiang
JohnNiang reviewed Jul 18, 2022
View reviewed changes
theme/README.md Outdated Show resolved Hide resolved
theme/README.md Outdated Show resolved Hide resolved
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 18, 2022
JohnNiang
JohnNiang reviewed Jul 18, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2022
ruibaby
ruibaby reviewed Jul 18, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

ruibaby
ruibaby reviewed Jul 18, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2022
@ruibaby
Copy link
Member

ruibaby commented Jul 18, 2022

/unhold

#17 已合并。

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit e41193e into halo-dev:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wan92hen wan92hen wan92hen left review comments

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang left review comments

Assignees

@JohnNiang JohnNiang

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guqing @ruibaby @JohnNiang @wan92hen