feature: add setting config design #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
the
release-note-none
guqing
force-pushed
the
feature/config-setting
branch
from
80122bb
to
ce7976c
Compare
wan92hen
reviewed
Jul 6, 2022
JohnNiang
reviewed
Jul 11, 2022
ok |
建议把参考链接放到 RFC 中。 |
在RFC内容中关于ConfigMap描述那段具有一个链接，需要在明确一下吗 |
已补充 |
JohnNiang
requested changes
Jul 12, 2022
guqing
force-pushed
the
feature/config-setting
branch
from
bbfc01e
to
b0c5a96
Compare
guqing
force-pushed
the
feature/config-setting
branch
from
b0c5a96
to
64a9ccd
Compare
JohnNiang
requested changes
Jul 12, 2022
Merged
f2c-ci-robot
bot
added
the
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?
新增主题和插件配置设计
参考：ConfigMap in kubernetes
Formkit form generation
/cc @halo-dev/sig-docs