-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic provenance tracking #28
Conversation
@armish I'm writing up a small test right now, and decided I should probably disable the warnings by default. |
provenance_set_previous = provenance_set_from_df(df_provenance_previous) | ||
new_provenance_diff = provenance_set.difference(provenance_set_previous) | ||
old_provenance_diff = provenance_set_previous.difference(provenance_set) | ||
if new_provenance_diff != set(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about something like:
def check_diff(diff):
if diff != set():
print("Current provenance for patient %s: %s" % (
patient_id, provenance_str_from_set(diff)))
check_diff(new_provenance_diff)
check_diff(old_provenance_diff)
to reduce the redundancy here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reduced the redundancy somewhat differently, let me know if it looks good?
nice one! 👏 Just a few minor questions/comments for you. Feel free to merge it when/if you address/ignore them. |
Updates:
|
@armish Good to merge on green? |
Fixes #15 |
Go for it! BTW: I think this looks much better with |
Since I'm regenerating a shared cache right now, I figured I'd knock out some basic provenance tracking this time around.
What this does:
Future work:
NetMHC*
versions.logging
rather thanprint
statements and have a way to suppress and/or merge the many warnings.