modify setup.py to reference requirements.txt #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not too worried about including It might be cleaner to separate them out at some point, but for now this seems fine to me. |
| from setuptools import setup | ||
| import versioneer | ||
|
|
||
| here = path.abspath(path.dirname(__file__)) |
There was a problem hiding this comment.
Duplicate logic/lines for grabbing the README path vs. the requirements.txt?
| @@ -37,6 +40,12 @@ | |||
| print("Failed to convert %s to reStructuredText", readme_filename) | |||
| pass | |||
|
|
|||
| # get the dependencies and installs | |||
| with open(path.join(here, 'requirements.txt'), encoding='utf-8') as f: | |||
There was a problem hiding this comment.
Nit: double quotes to match the rest of the file?
|
LGTM, feel free to merge when Travis passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified
setup.pyto load install_requires fromrequirements.txt.This should address situations like that seen in issue #69, which we thought we had fixed (by freezing
isovarversion) but it turned out we hadn't truly fixed -- we only changed isovar inrequirements.txtbut not insetup.py. Since requirements.ext was used to set up the travis testing environment, this failure to modifysetup.pywasn't caught.One downside of loading all packages from
requirements.txtintosetup.pyis that we end up with utility packages likepylintincluded as requirements for cohorts. Same would go for packages required for testing, which may or may not be required for package function.We could avoid this situation by having separate "package_requirements.txt" & "travis_requirements.txt" files, only one of which would be used to populate
setup.py. But, maintaining separate files introduces the potential for the problem to re-occur.Packages like
pylintare hard-coded into the .travis-ci.yml and so could probably be taken out of thisrequirements.txtfile entirely.