Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DEVELOP.md #773

Merged
merged 2 commits into from
Jul 1, 2015
Merged

Update DEVELOP.md #773

merged 2 commits into from
Jul 1, 2015

Conversation

ihodes
Copy link
Member

@ihodes ihodes commented Jul 1, 2015

Add info about daemonizing SauceConnect

Review on Reviewable

Add info about daemonizing SauceConnect
@danvk
Copy link
Contributor

danvk commented Jul 1, 2015

Please include the bit about --wait, too. You may want to verify with @jaclynperrone that this did actually speed up the update-screenshots command (if it did, we're not seeing any evidence of it).

@ihodes
Copy link
Member Author

ihodes commented Jul 1, 2015

The --wait flag is seltest specific. I'd rather point to the docs then re-document seltest here. (Additionally, interactive is more useful than wait). 

I'd be surprised if this isn't speeding the script up. Will take a look at it on her machine.

On Wed, Jul 1, 2015 at 2:47 PM, Dan Vanderkam notifications@github.com
wrote:

Please include the bit about --wait, too. You may want to verify with @jaclynperrone that this did actually speed up the update-screenshots command (if it did, we're not seeing any evidence of it).

Reply to this email directly or view it on GitHub:
#773 (comment)

@jaclynperrone
Copy link
Contributor

@ihodes That would be super helpful! It's taken about 5 minutes to generate the first 8 screenshots.

@danvk
Copy link
Contributor

danvk commented Jul 1, 2015

Mentioning that --wait and sel interactive are useful & linking off to the docs would be really helpful. Neither Jaclyn nor I knew to try those.

@danvk danvk closed this Jul 1, 2015
@danvk danvk reopened this Jul 1, 2015
@ihodes
Copy link
Member Author

ihodes commented Jul 1, 2015

I'll add some notes + pointers, makes sense.

FTR, the slowness appears to be the tunnel between sauce and our office is slow today; we observed this on the SauceLabs videos (pages just taking a long time to load), and saw that the tests when connecting to Travis is much faster.

@ihodes
Copy link
Member Author

ihodes commented Jul 1, 2015

@dan back to you (I left out --wait as mentioned, as I wouldn't recommended it).

danvk added a commit that referenced this pull request Jul 1, 2015
@danvk danvk merged commit c779180 into master Jul 1, 2015
@ihodes ihodes deleted the develop-seltest-daemonize-sc branch December 23, 2015 16:53
@hammer hammer unassigned danvk Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants