rm "-fasta" from reference-param name #580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also rm unused ReferenceArgs
|
Changes Unknown when pulling d2b0fb1 on ryan-williams:ref into * on hammerlab:master*. |
|
This PR seems like it was merged in already? The diff is empty except for an empty line removed? |
|
Weird, yea this commit ended up on #579; I don't think that was intentional / know when it was added there relative to your review, sorry! Let me know if you have any comments on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it can be a
.fasta.gz, making the previous name a bit ambiguous, and both previous ref args were unnecessarily verboseThis change is