Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GA4GHAlignments to be accessible through raw json #460

Merged
merged 2 commits into from
Jun 21, 2017

Conversation

akmorrow13
Copy link
Collaborator

@akmorrow13 akmorrow13 commented Jun 15, 2017

This is primarily to allow pileup.js to be used in platforms other than the browser. For example, a user can load data into a pandas data frame in python, and pipe the dataframe using the to_json() function into pileup. Since python notebook supports html and JS, one can immediately view their in the same environment.

I think I will eventually add similar functionality for variants, features, etc. but thought this is a good starting point for discussion.


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 90.93% when pulling c09531b on akmorrow13:json-python into 8b7ef01 on hammerlab:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 90.94% when pulling bfa734f on akmorrow13:json-python into 8b7ef01 on hammerlab:master.

@armish
Copy link
Member

armish commented Jun 21, 2017

Thanks, @akmorrow13! This is great — notebook integration has been something on our todo list since early days (#297)

If you get it to work fully, would love to test it out and put an example on the repo.

@armish armish merged commit 3859912 into hammerlab:master Jun 21, 2017
@akmorrow13
Copy link
Collaborator Author

Hi @armish ! Tagging @jpdna for interest. The reads visualization already works in a widget (with my personal pileup branch with these JSON changes). The widget repo can be found here: https://github.com/akmorrow13/genomicviz

This is more of a wrapper, with pileup.js being the main focus. However, we will be adding in some other exciting visualizations, such as heat maps and stuff. Any useful viz recommendations would be welcome.

I am working to add variants and features next. First though, I will be adding GA4GH formats for these types into pileup.js. PR is coming soon!

@armish
Copy link
Member

armish commented Jun 21, 2017

@akmorrow13 @jpdna - that is amazing news! I will keep an eye on the project in case you need beta testers :)

@akmorrow13 akmorrow13 mentioned this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants