Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to in html #50

Merged
merged 3 commits into from
Feb 4, 2016
Merged

Link to in html #50

merged 3 commits into from
Feb 4, 2016

Conversation

davydovanton
Copy link
Member

Fixed #48
Also I fixed case when html helper called inside another html helper. For example:

html.div do
  span 'hello'
  html.div { span 'hanami' }
end

/cc @hanami/core-team

@runlevel5 runlevel5 added the bug label Feb 3, 2016
# html.label do
# p 'hello'
# html.span 'hanami'
# end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing @since

@runlevel5
Copy link
Member

👍

@davydovanton
Copy link
Member Author

@joneslee85 fixed. thanks for catch 👍

@runlevel5 runlevel5 added this to the v0.3.0 milestone Feb 4, 2016
runlevel5 pushed a commit that referenced this pull request Feb 4, 2016
@runlevel5 runlevel5 merged commit cae1e74 into hanami:master Feb 4, 2016
@davydovanton
Copy link
Member Author

@joneslee85 thanks 🌟

@davydovanton davydovanton deleted the link-to-in-html branch February 4, 2016 10:48
@jodosha jodosha added invalid and removed bug labels Feb 4, 2016
@jodosha jodosha removed this from the v0.3.0 milestone Feb 4, 2016
@jodosha jodosha self-assigned this Feb 4, 2016
@jodosha
Copy link
Member

jodosha commented Feb 4, 2016

@davydovanton @joneslee85 I'm reverting this, this implementation is too cluttered and reimplements link_to inside HTML builder.

@jodosha jodosha mentioned this pull request Feb 4, 2016
@davydovanton
Copy link
Member Author

@jodosha no problem. But do you have any ideas how I can solve this problem?

@jodosha
Copy link
Member

jodosha commented Feb 4, 2016

@davydovanton Please check #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors with calling link_to helper in html builder
3 participants