Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow links to be concat #52

Merged
merged 3 commits into from
Feb 4, 2016
Merged

Allow links to be concat #52

merged 3 commits into from
Feb 4, 2016

Conversation

jodosha
Copy link
Member

@jodosha jodosha commented Feb 4, 2016

Ref #48

@jodosha jodosha modified the milestone: next Feb 4, 2016
@jodosha jodosha mentioned this pull request Feb 4, 2016
@davydovanton
Copy link
Member

nice 👍

But also you need to realize #html helper too. Because you will have a problems with following code now too.

def two_spans_in_div
  html.div do
    span 'hello'
    html.span 'world'
  end
end

@jodosha
Copy link
Member Author

jodosha commented Feb 4, 2016

@davydovanton What's the point of using nested html calls?

@davydovanton
Copy link
Member

My hypothesis is that perhaps we'll have a problems with helpers based on html helper inside html block.
But now I see that all tests is passed.

jodosha added a commit that referenced this pull request Feb 4, 2016
@jodosha jodosha merged commit a6c9aea into master Feb 4, 2016
@jodosha jodosha deleted the allow-links-to-be-concat branch February 4, 2016 17:47
@jodosha jodosha self-assigned this Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants