-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.30.0+] Fill handle double-click fills left instead of down #5023
Labels
Auto fill
Plugin
bug
Regression
Issues that were created while adding new changes to the source code
Status: Released
Milestone
Comments
Here's how the example worked before we made a refactor in v
|
AMBudnik
added
the
Regression
Issues that were created while adding new changes to the source code
label
Apr 20, 2018
AMBudnik
changed the title
Fill handle double-click fills left instead of down
[0.30.0+] Fill handle double-click fills left instead of down
Apr 20, 2018
I am also suffering from this problem |
pnowak
added a commit
that referenced
this issue
Sep 3, 2018
6 tasks
pnowak
pushed a commit
that referenced
this issue
Sep 5, 2018
pnowak
added
Status: Merged (ready for release)
and removed
Status: In development
labels
Sep 5, 2018
5.0.2-RC: https://jsfiddle.net/rdhktn3f/ 👍 |
Thank you. Issue solved in v 5.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Auto fill
Plugin
bug
Regression
Issues that were created while adding new changes to the source code
Status: Released
Description
When you double-click the fill handle for a cell, the value in that cell should be autofilled into all of the cells below it as long as data has been entered in the cell to the left of the one being filled. This works correctly as long as there is at least one applicable cell to fill.
If the column to the left is empty, then double-clicking the fill handle causes the autofill to happen sideways, filling all cells to the left. The same happens if there is data in one cell to the left, but not in any below.
Steps to reproduce
Demo
https://jsfiddle.net/6zgv3exz/15/
If you double-click the fill handle on the cell containing '2', the value is autofilled down as expected. If you double-click the fill handle on either of the cells containing '3' or '4', the value is autofilled left instead.
Possible solution
Initializing
lastFilledInRowIndex
to-1
here probably fixes the problem, which occurs when the following loop has zero iterations.I have made a different change to my local copy as we wanted the autofill to extend to the bottom of the table regardles of whether there is any data to the left.
Your environment
The text was updated successfully, but these errors were encountered: