Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed margins for context-menu in RTL mode and fixed problem with wrong position for check inside Read only entry #10375

Merged
merged 6 commits into from
May 22, 2023
Merged

Changed margins for context-menu in RTL mode and fixed problem with wrong position for check inside Read only entry #10375

merged 6 commits into from
May 22, 2023

Conversation

wszymanski
Copy link
Contributor

Context

This PR changed a way how context-menu looks like in RTL mode (margins). It also did changes to place check inside Read only entry at proper position. It fixes problem described in #752 issue.

How has this been tested?

I checked how layoutDirection works.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. #752

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

  • I have reviewed the guidelines about Contributing to Handsontable and I confirm that my code follows the code style of this project.
  • My change requires a change to the documentation.

@wszymanski wszymanski requested a review from budnix May 17, 2023 14:53
@wszymanski wszymanski self-assigned this May 17, 2023
budnix
budnix requested changes May 22, 2023
View reviewed changes
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I've left some suggestions about code improvements to consider.

handsontable/src/plugins/contextMenu/contextMenu.scss Outdated Show resolved Hide resolved
handsontable/src/plugins/dropdownMenu/dropdownMenu.scss Outdated Show resolved Hide resolved
@wszymanski wszymanski requested review from budnix May 22, 2023 09:58
budnix
budnix approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@wszymanski wszymanski merged commit 4700084 into develop May 22, 2023
@wszymanski wszymanski deleted the feature/issue-dev-752 branch May 22, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budnix budnix Awaiting requested review from budnix

Assignees

@wszymanski wszymanski

Labels
Status: Released Verified by QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wszymanski @budnix @AMBudnik @aninde