Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed table misalignment caused by CSS transform scale property #10482

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

budnix
Copy link
Member

@budnix budnix commented Aug 29, 2023

Context

The PR fixes the table size and misalignment when it runs in the scaled container using the CSS transform option (e.g., transform: scale(0.75)).

How has this been tested?

I tested the changes locally and covered the fix with a visual test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/713

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Aug 29, 2023
@budnix budnix marked this pull request as ready for review August 29, 2023 11:06
@budnix budnix requested a review from wszymanski August 29, 2023 11:14
@budnix budnix changed the title Fixed table misalignment when it runs in the scaled container. Fixed table misalignment caused by CSS transform scale property Aug 29, 2023
Copy link
Contributor

@wszymanski wszymanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@budnix budnix merged commit 3580238 into develop Aug 31, 2023
29 checks passed
@budnix budnix deleted the feature/dev-issue-713 branch August 31, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants