Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantile normalization after Noob #165

Closed
DelnazR opened this issue Jun 12, 2018 · 4 comments
Closed

Quantile normalization after Noob #165

DelnazR opened this issue Jun 12, 2018 · 4 comments

Comments

@DelnazR
Copy link

DelnazR commented Jun 12, 2018

I would like to do Quantile normalization after Noob, but when I use the MSet or GMset out of preprocessNoob as an input for preprocessQuantile I get the following error:

Error in if ((is(object, "MethylSet") || is(object, "GenomicMethylSet")) && :
missing value where TRUE/FALSE needed

@PeteHaitch
Copy link
Contributor

I'll take a look. Can you please post a minimal reproducible example and include the output of BiocInstaller::biocValid()?

@PeteHaitch
Copy link
Contributor

reprex on devel branch with minfi v1.27.1:

suppressPackageStartupMessages(library(minfiData))
MsetEx.sub.noob <- preprocessNoob(RGsetEx.sub)
#> [dyeCorrection] Applying R/G ratio flip to fix dye bias
preprocessQuantile(MsetEx.sub.noob)
#> Error in if ((is(object, "MethylSet") || is(object, "GenomicMethylSet")) && : missing value where TRUE/FALSE needed

@PeteHaitch PeteHaitch changed the title Quntile normalization after Noob Quantile normalization after Noob Jun 13, 2018
@PeteHaitch
Copy link
Contributor

PeteHaitch commented Jun 13, 2018

The obscure error message is due to a bug in how we check for previous pre-processing applied to the input object. I am fixing this in release and devel branches.

The intended behaviour is to issue the warning, preprocessQuantile has only been tested with 'preprocessRaw'. That is to say, if you use preprocessQuantile() following any other pre-processing method, such as preprocessNoob(), then you're on your own because this has not been tested by the minfi authors.

PeteHaitch added a commit that referenced this issue Jun 13, 2018
@DelnazR
Copy link
Author

DelnazR commented Jun 13, 2018

Thanks Pete for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants