Add ability to patch joi schemas with Toys #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Apr 17, 2021
devinivy
reviewed
Apr 17, 2021
devinivy
reviewed
Apr 17, 2021
devinivy
reviewed
Apr 17, 2021
|
All done now! |
devinivy
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
Toys.patchJoiSchemato Toys. This allows us to use Toys to generate patch schemas which seems to be a recurring topic in our Slack community.A couple of points from me:
to.be.an.object()is sufficient in this case. Arguably, the returned schema is already tested in joi but happy to amend this if you like.Cheers 🥂