Improve performance of similar enough images #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was tracking down a performance issue with a large diff on happo.io and found that the shortcut we take when images are "similar enough" wasn't fast enough. The hashing process takes a little while on large images and we don't really need the hashing for the similarEnough function to run. I rewrote it so that it would operate on unhashed image arrays instead, plus made it early-bail so that we won't have to iterate through the whole image when we already know it's not similar enough.
|
I gave this a try on a diff on a 800px x 5000px image and it cuts down diffing time by approximately 2s (Down from 4s to 2s). Still not great but at least a lot better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was tracking down a performance issue with a large diff on happo.io
and found that the shortcut we take when images are "similar enough"
wasn't fast enough. The hashing process takes a little while on large
images and we don't really need the hashing for the similarEnough
function to run. I rewrote it so that it would operate on unhashed image
arrays instead, plus made it early-bail so that we won't have to iterate
through the whole image when we already know it's not similar enough.