BUG/MINOR: controller: Fix wildcard host matching with route-acl #735
+271
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to have this reviewed @oktalz :) This would help us a lot, it's blocking a release on our side, and it benefits all HAProxy users with the same use case |
SF97
force-pushed
the
master
branch
3 times, most recently
from
ae555e5 to
3589039
Compare
When an Ingress resource used a wildcard host (e.g., `*.example.com`)
in combination with the `haproxy.org/route-acl` service annotation,
the controller would generate an incorrect HAProxy ACL. It used an
exact string match (`-m str`) on the literal value `*.example.com`,
which would fail to match any intended subdomains.
This patch modifies the route generation logic to inspect the hostname.
If the host begins with an asterisk ('*'), it now correctly generates an
ACL using a suffix match (`-m end`) and removes the leading asterisk
from the hostname string.
For non-wildcard hosts, the original behavior of using an exact string
match (`-m str`) is preserved.
Fixes: haproxytech#734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an Ingress resource used a wildcard host (e.g.,
*.example.com) in combination with thehaproxy.org/route-aclservice annotation, the controller would generate an incorrect HAProxy ACL. It used an exact string match (-m str) on the literal value*.example.com, which would fail to match any intended subdomains.This patch modifies the route generation logic to inspect the hostname. If the host begins with an asterisk ('*'), it now correctly generates an ACL using a suffix match (
-m end) and removes the leading asterisk from the hostname string.For non-wildcard hosts, the original behavior of using an exact string match (
-m str) is preserved.Fixes: #734