repackage URIBL as npm plugin #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uribl: only register hooks when URIBL zones are configured - uribl: timeout DNS 1 second before plugin
so that timers will fire before plugin times out
|
This pull request fixes 1 alert when merging 76855d0 into e5e679e - view on LGTM.com fixed alerts:
|
msimerson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only timer in the plugin (in do_lookups) wasn't consistently started at the beginning of plugin hooks. On the lookup_rdns hook, the function first did a rDNS lookup, which took some variable amount of time, then launched do_lookups, which did some more lookups, this time with a timer, but the timer wasn't shorter than the plugin timeout, so you could easily get DNS timeout errors in the logs.
Checklist: