Skip to content

Fix location of scripts #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 6, 2018
Merged

Fix location of scripts #406

merged 15 commits into from
Sep 6, 2018

Conversation

felixdivo
Copy link
Collaborator

@felixdivo felixdivo commented Sep 5, 2018

  1. Placing the scripts in a separate module in can.modules.* instead of can.* made them impossible to be called the old way, even with them being present in the can/__init__.py. Thus, the relocation of the scripts to the separate module is reverted.
  2. Now, the scripts print the help message when no arguments were given.
  3. Adds some tests to ensure that the scripts can always be called.

Fix #392

@felixdivo felixdivo added this to the 2.3 Release milestone Sep 5, 2018
@felixdivo felixdivo self-assigned this Sep 5, 2018
@codecov
Copy link

codecov bot commented Sep 6, 2018

Codecov Report

Merging #406 into develop will decrease coverage by 3.87%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #406      +/-   ##
===========================================
- Coverage    59.26%   55.38%   -3.88%     
===========================================
  Files           55       54       -1     
  Lines         4328     4407      +79     
===========================================
- Hits          2565     2441     -124     
- Misses        1763     1966     +203

@felixdivo felixdivo merged commit 029564b into develop Sep 6, 2018
@felixdivo felixdivo deleted the fix_scripts branch September 6, 2018 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants