Fix unary minus operator applied to unsigned int #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying unary minus operator to unsigned int causes the following error on MSVS: error C4146 This patch fixes the error.
|
This change caused the following ubsan failure, which is reported as https://crbug.com/1050424 |
ebraminio
added a commit
that referenced
this pull request
Feb 11, 2020
Newer versions of MSVC with /we4146 don't like putting negative sign behind a unsigned number as #2069 That however have made https://crbug.com/1050424 this complain: src/hb-ot-color-sbix-table.hh:304:28: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself which apparently can be fixed using this change. Let's see if this won't make another ubsan complain!
|
Have applied ff984ed wondering if that won't make another ubsan complain, let's see. Someone should add the flag, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying unary minus operator to unsigned int causes the following error on MSVS: error C4146
This patch fixes the error.