Add hb-set-fuzzer. #2161
Merged
Add hb-set-fuzzer. #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think we can have hb-map on the same fuzzer, or both on shape or
subset fuzzers, just am thinking about carbon footprint of adding one other
fuzzer
…On Fri, Feb 7, 2020, 00:37 Garret Rieger ***@***.***> wrote:
@garretrieger <https://github.com/garretrieger> requested your review on:
#2161 <#2161> Add hb-set-fuzzer..
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#2161?email_source=notifications&email_token=AAGLPQOHDRVP5K5RISAKVM3RBR3ZDA5CNFSM4KREAC7KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWO6KJUY#event-3015484627>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGLPQKDNWKZDXY5CCDRXJDRBR3ZDANCNFSM4KREAC7A>
.
|
|
I think it's better to have each fuzzer specific to the area of code/api it's attempting to fuzz, since the data input will be pretty specific to that api. Setting up additional fuzz targets on oss-fuzz is pretty light weight so no concern there. I can add a separate fuzzer for hb_map_t. |
ebraminio
approved these changes
Feb 10, 2020
garretrieger
force-pushed
the
set_fuzzer
branch
from
6b6de9c
to
394946f
Compare
It fuzzes all of the hb_set process methods (intersection, subtraction, union, and symmetric difference).
garretrieger
force-pushed
the
set_fuzzer
branch
from
394946f
to
5b17e72
Compare
|
Feel free to hb_map_t fuzzer also :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fuzzes all of the hb_set process methods (intersection, subtraction, union, and symmetric difference).