Meson test api c files build fix #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. and simplify, can pass two languages in one go. add_global_arguments() won't work if harfbuzz is used as a meson subproject.
Fixes compiler warning test-unicode.c:589:1: warning: ‘test_unicode_properties_lenient’ defined but not used which didn't happen with autotools. Reason it does with meson is that the setup for C was slightly wrong. We would only add -DHAVE_CONFIG_H to cpp_args which is only valid when compiling C++ code, but not plain C code, and many of these tests were plain C. Instead pass -DHAVE_CONFIG_H via add_project_arguments() and make sure to set both c_args and cpp_args when building test executables. Fixes harfbuzz#2257
|
Our meson-gcc bot https://github.com/harfbuzz/harfbuzz/blob/master/.circleci/config.yml#L227-L238 fails https://app.circleci.com/pipelines/github/harfbuzz/harfbuzz/jobs/133013 with the changes apparently, can you have a look? Thanks :) |
|
Can reproduce the CI failure locally with |
tp-m
force-pushed
the
meson-test-api-c-files-build-fix
branch
2 times, most recently
from
efba55a
to
f329f1d
Compare
test-unicode.c:960: undefined reference to `hb_icu_get_unicode_funcs' test-unicode.c:961: undefined reference to `hb_icu_get_unicode_funcs' For now add the icu sources to libharfbuzz also for the amalgam build, later we need to have a separate harfbuzz-icu module and link against that, and/or generate harfbuzz.cc.
tp-m
force-pushed
the
meson-test-api-c-files-build-fix
branch
from
f329f1d
to
cfadb01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 1322eba:
commit 7c24cc3: