fix consensus catchup issue #4474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GheisMohammadi
requested review from
Frozen,
sophoah,
MaxMustermann2 and
ONECasey
MaxMustermann2
approved these changes
Jul 28, 2023
ONECasey
approved these changes
Jul 28, 2023
sophoah
approved these changes
Jul 31, 2023
GheisMohammadi
force-pushed
the
fix/consensus_catchup
branch
from
53fb56a
to
8740c31
Compare
GheisMohammadi
force-pushed
the
fix/consensus_catchup
branch
from
8740c31
to
a5634ed
Compare
Frozen
approved these changes
Aug 3, 2023
This was referenced Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Current logs show many issues like the one below:
The issue is that the current code only joins consensus if the client is enabled, but it doesn't check the stream downloader. Therefore, if the node wants to disable DNS sync and only use the stream, it won't run
supportSyncing, and as a result, it won't join consensus. This means that theVerifiedNewBlockchannel will always be full, and new blocks will not be sent to unsynced nodes. Consequently, it will produce the catchup issue. This PR fixes this issue by adding a simple check for the downloader as well.