fix getTransactionReceipt response #4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diego1q2w
requested review from
Frozen,
sophoah,
GheisMohammadi,
adsorptionenthalpy and
ONECasey
|
good job, it would be great if you can add a test for the new method NewReceiptFromTransaction. |
adsorptionenthalpy
approved these changes
Dec 18, 2023
Frozen
approved these changes
Dec 18, 2023
ONECasey
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue in the v2 package where certain integer fields in the transaction receipt were not correctly serialized in hexadecimal format such as (gas, blocknumber, etc). This PR introduces a new Receipt method for transactions within the
ethpackage, ensuring all integer fields are properly converted to hexadecimal representation.