rpc: fix the from address calculation
#4593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were skipped intentionally in the previous pull request
`tx.ConvertToEth` silently drops the `ShardID` and `ToShardID` fields. This results in the hash of the transaction changing (either via removal of these fields in the hash calculation or by automatic filling of the values by the node's shard). The different hash calculation results in incorrect sender address calculation. There have been a couple of attempts to fix this issue, which created troubles elsewhere. This pull request reverts to the behaviour seen in 2023.3.0 with a simple edit that calculates the `SenderAddress` before dropping the fields in the call to `ConvertToEth`.
diego1q2w
approved these changes
Dec 19, 2023
sophoah
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpc: calculate SenderAddress before
ConvertToEthtx.ConvertToEthsilently drops theShardIDandToShardIDfields.This results in the hash of the transaction changing (either via removal
of these fields in the hash calculation or by automatic filling of the
values by the node's shard). The different hash calculation results in
incorrect sender address calculation.
There have been a couple of attempts to fix this issue, which created
troubles elsewhere. This pull request reverts to the behaviour seen in
2023.3.0 with a simple edit that calculates the
SenderAddressbeforedropping the fields in the call to
ConvertToEth.