Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block proposing moved from Node to Consensus. #4698

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Block proposing moved from Node to Consensus. #4698

merged 1 commit into from
Jun 25, 2024

Conversation

Frozen
Copy link
Contributor

@Frozen Frozen commented Jun 21, 2024

  1. Block proposing uses 99% consensus and 1% node code, but it is located within the node.
  2. The chained protocol requires block proposing from consensus, causing a circular dependency error.

@Frozen Frozen self-assigned this Jun 21, 2024
sophoah
sophoah reviewed Jun 24, 2024
View reviewed changes
internal/utils/utils.go
func GetPendingCXKey(shardID uint32, blockNum uint64) string {
key := strconv.FormatUint(uint64(shardID), 10) + "-" + strconv.FormatUint(blockNum, 10)
return key
func GetPendingCXKey(shardID uint32, blockNum uint64) CXKey {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the difference of key format returned cause any issue in our codebase calling that function ?

Copy link
Contributor Author

@Frozen Frozen Jun 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cache keeped only in the memory, so, restart will erase everything.
Exactly in this case, we have 4 memory allocations for no reason. My version has no allocations.

@ONECasey ONECasey merged commit d6da9ff into dev Jun 25, 2024
4 checks passed
@sophoah sophoah mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophoah sophoah sophoah left review comments

@ONECasey ONECasey ONECasey approved these changes

@adsorptionenthalpy adsorptionenthalpy adsorptionenthalpy approved these changes

@GheisMohammadi GheisMohammadi Awaiting requested review from GheisMohammadi

Assignees

@Frozen Frozen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Frozen @sophoah @adsorptionenthalpy @ONECasey