Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed trailing zeros. #4709

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Removed trailing zeros. #4709

merged 1 commit into from
Jul 19, 2024

Conversation

Frozen
Copy link
Contributor

@Frozen Frozen commented Jul 6, 2024

Removed trailing zeros.

@Frozen Frozen self-assigned this Jul 6, 2024
@GheisMohammadi
Copy link
Contributor

could you please explain the changes and the reason for removing trailing zeros?

@Frozen
Copy link
Contributor Author

Frozen commented Jul 18, 2024

could you please explain the changes and the reason for removing trailing zeros?

Reason is not to have tests like this NewDec(12340), "12340.000000000000000000", and have like this NewDec(12340), "12340"

@sophoah sophoah merged commit 252bda9 into dev Jul 19, 2024
4 checks passed
@sophoah sophoah mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ONECasey ONECasey ONECasey approved these changes

@adsorptionenthalpy adsorptionenthalpy adsorptionenthalpy approved these changes

@GheisMohammadi GheisMohammadi GheisMohammadi approved these changes

@sophoah sophoah sophoah approved these changes

Assignees

@Frozen Frozen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Frozen @GheisMohammadi @sophoah @adsorptionenthalpy @ONECasey