fix boot node invalid address issue #4724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The following part of code from
cmd/bootnode/main.go
:prints the bootnode address in the format
BN_MA=<address>
. If any output is printed after this line, it will be appended to the same line.In the
deploy.sh
script, the bootnode address is extracted using thelaunch_bootnode
function:This function maps the terminal log to a log file and assumes that the line containing
BN_MA
in the log file contains only the bootnode address.So, If additional output is appended to the same line as the
BN_MA
address, the script's extraction method may fail, leading to incorrect parsing of the bootnode address. This can cause to boot failure and other issues in subsequent steps that rely on the correct bootnode address.This PR addresses this issue. It prints the address on a new line and no further output is appended to it.