Skip to content

Conversation

davejohnston
Copy link
Contributor

  • Added default target 'all'. Just running make should be enough to build, check and test the code
  • Use go env to determine the correct place to install binaries
  • Updated the version of the linter being used
  • introduced gofmt, gosec and golint checks. These are run automatically as part of all
  • Added goreport card to README.md

Additional changes to the code are a result of running gofmt.

Dave Johnston added 2 commits March 3, 2021 19:14
…cking code

* Added default target 'all'.  Running ```make``` should be enough
 to build, check and test the code

* Updated the version of the linter being used
* introduced gofmt, gosec and golint checks.  These are run automatically as part of all
Copy link
Contributor

@enver-bisevac enver-bisevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done :)

@davejohnston davejohnston merged commit 6c0f496 into harness:main Mar 4, 2021
@davejohnston davejohnston deleted the maint/fix_linter branch March 4, 2021 13:32
rushabh-harness pushed a commit that referenced this pull request Mar 23, 2021
setup versioning and fixed issue with segmentMatch operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants