[FFM-1262] polling processor, streaming processor #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knagurski
reviewed
Sep 6, 2021
Comment on lines
+28
to
+34
| eventBus.on(Event.CONNECTED, () => { | ||
| this.stop(); | ||
| }); | ||
|
|
||
| eventBus.on(Event.DISCONNECTED, () => { | ||
| this.resume(); | ||
| }); |
There was a problem hiding this comment.
Oh, I think I get it now. So when the stream connects the polling stops. It might be a bit more obvious how it works if you pull this up to the parent class and let the PollingProcessor be a little bit more dumb.
There was a problem hiding this comment.
OK, I will make stop() and resume() public methods and from ClientFC make proper calls
knagurski
reviewed
Sep 7, 2021
| import { StreamProcessor } from './streaming'; | ||
| import * as events from 'events'; | ||
|
|
||
| export class CfClient { |
There was a problem hiding this comment.
Not sure I'd consider this in the scope of this ticket, but since we no longer use "Continuous Features", should this be FFClient?
knagurski
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.