Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show up errors from cru-resource component when editing images (backport #1032) #1035

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 31, 2024

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related issue harvester/harvester#5901

Occurred changes and/or fixed issues

Technical notes summary

Resolved by passing the errors from EditImage component to the CruResource to by displayed on top

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

image


This is an automatic backport of pull request #1032 done by [Mergify](https://mergify.com).

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
(cherry picked from commit 74e6c6a)
@torchiaf torchiaf merged commit 05892d5 into release-harvester-v1.3 May 31, 2024
7 checks passed
@mergify mergify bot deleted the mergify/bp/release-harvester-v1.3/pr-1032 branch May 31, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants